Skip to content

Don't try to insert queue records if no downstream dag #26257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashb merged 1 commit into from
Sep 9, 2022
Merged

Don't try to insert queue records if no downstream dag #26257

ashb merged 1 commit into from
Sep 9, 2022

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Sep 9, 2022

No description provided.

kaxil
kaxil reviewed Sep 9, 2022
View reviewed changes
@kaxil kaxil added the AIP-48 label Sep 9, 2022
@ashb ashb added this to the Airflow 2.4.0 milestone Sep 9, 2022
@dstandish @ashb
Don't blow up when a task produces a dataset that is not consumed.
f0ba0ac 
If you had a dataset outlut on a task, and no DAG was recorded as
consuming that dataset it failed with a null value constraint violation
in the db
@ashb ashb force-pushed the check-if-deps-before-running-insert branch from a8c2d17 to f0ba0ac Compare September 9, 2022 10:59
@ashb ashb requested a review from kaxil September 9, 2022 10:59
@ashb ashb merged commit fe82e96 into apache:main Sep 9, 2022
@ashb ashb deleted the check-if-deps-before-running-insert branch September 9, 2022 13:04
ashb pushed a commit that referenced this pull request Sep 9, 2022
@dstandish @ashb
Don't blow up when a task produces a dataset that is not consumed. (#…
ea22657 
…26257)

If you have a dataset outlet on a task, and no DAG was recorded as
consuming that dataset it failed with a null value constraint violation
in the db

(cherry picked from commit fe82e96)
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 12, 2022
@eladkal eladkal added area:data-aware-scheduling assets, datasets, AIP-48 and removed AIP-48 labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb ashb left review comments

@kaxil kaxil kaxil approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

Assignees

No one assigned

Labels

area:data-aware-scheduling assets, datasets, AIP-48 changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

Airflow 2.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dstandish @ashb @kaxil @eladkal @jedcunningham