Flush dataset events before queuing dagruns #26276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we go to schedule dagruns from the dataset dagrun queue, we assume the events will happen before the queue records, which isn't the case unless we explicitly flush them first. This ensures that dagruns are properly related to their upstream dataset events.
boring-cyborg
bot
added
the
area:Scheduler
jedcunningham
added
changelog:skip
dstandish
approved these changes
Sep 9, 2022
jedcunningham
added a commit
that referenced
this pull request
Sep 12, 2022
When we go to schedule dagruns from the dataset dagrun queue, we assume the events will happen before the queue records, which isn't the case unless we explicitly flush them first. This ensures that dagruns are properly related to their upstream dataset events. (cherry picked from commit 954349a)
eladkal
added
area:data-aware-scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we go to schedule dagruns from the dataset dagrun queue, we assume the events will happen before the queue records, which isn't the case unless we explicitly flush them first. This ensures that dagruns are properly related to their upstream dataset events.
Fixes #26256