Skip to content

GoogleAPIToS3Operator System Test (AIP-47)#26370

Merged
potiuk merged 4 commits intoapache:mainfrom
aws-mwaa:syedahsn/google-api-youtube-to-s3
Sep 21, 2022
Merged

GoogleAPIToS3Operator System Test (AIP-47)#26370
potiuk merged 4 commits intoapache:mainfrom
aws-mwaa:syedahsn/google-api-youtube-to-s3

Conversation

@syedahsn
Copy link
Contributor

Convert example DAG to System test using template in (#24643)[https://github.com//pull/24643]
Also update the parse_s3_url function in S3Hook to work with different valid formats. Tests included.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Sep 18, 2022

Needs conflicts to be resolved.

Uses xcom to pass data between tasks to retrieve specific information about YouTube videos
Update parse_s3_url function to work with S3:// format, Path-style, and Virtual-hosted–style.
	See https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html
@syedahsn syedahsn force-pushed the syedahsn/google-api-youtube-to-s3 branch from 8c7371e to 752a174 Compare September 19, 2022 16:51
@syedahsn syedahsn requested a review from mik-laj as a code owner September 19, 2022 19:11
@potiuk potiuk merged commit 5b2d0e0 into apache:main Sep 21, 2022
@vandonr-amz vandonr-amz deleted the syedahsn/google-api-youtube-to-s3 branch May 24, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants