Better validation of Dataset URI during dag parse #26389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
uri-length-check
branch
from
1e31a24 to
bb9c320
Compare
Contributor
|
Might be worth retiring |
Member
Author
I considered that, but we do still have validation on the model -- should we keep that or not? |
Member
Author
|
Oh, those are testing the public dataset class (after the refactor the test got changed, but not the location), not the model. Yeah I'll remove those tests! |
ashb
force-pushed
the
uri-length-check
branch
from
bb9c320 to
6d3c333
Compare
ashb
added
the
changelog:skip
ashb
force-pushed
the
uri-length-check
branch
3 times, most recently
from
ce9e374 to
5038bf4
Compare
Member
Author
|
Fail Ash. (New dev env, don't have pre-commit set up there yet) |
Previously we had the validation on the Dataset model, but we since moved the "dag" facing class to a separate one. This adds validation to the public class, and extends the validation to not allow space-only strings
ashb
force-pushed
the
uri-length-check
branch
from
5038bf4 to
c74dfb6
Compare
Member
|
The failure is due to #26382 I think -- where we forgot to add it to rat_exclude? |
Member
Yep, unrelated to this one. |
Member
Author
|
Failure is on main, merging. |
Member
Author
|
#26396 to fix main. |
jedcunningham
approved these changes
Sep 14, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 15, 2022
Previously we had the validation on the Dataset model, but we since moved the "dag" facing class to a separate one. This adds validation to the public class, and extends the validation to not allow space-only strings (cherry picked from commit bd181da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had the validation on the Dataset model, but we since moved the "dag" facing class to a separate one. This adds validation to the public class, and extends the validation to not allow space-only strings
Closes #26380