Add min attrs version #26408
Merged
Add min attrs version #26408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure when we started using attrs directly, but we do and we need >=22.1.0 as we use the min_length validator.
jedcunningham
requested review from
ashb,
dstandish,
ephraimbuddy and
potiuk
potiuk
approved these changes
Sep 14, 2022
dstandish
approved these changes
Sep 14, 2022
jedcunningham
added a commit
that referenced
this pull request
Sep 15, 2022
I'm not sure when we started using attrs directly, but we do and we need >=22.1.0 as we use the min_length validator. (cherry picked from commit fdecf12)
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when we started using attrs directly, but we do and we need
>=22.1.0 as we use the min_length validator.