Skip to content

Redshift to S3 and S3 to Redshift System test (AIP-47) #26613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Sep 26, 2022
Merged

Redshift to S3 and S3 to Redshift System test (AIP-47) #26613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b836c08
System test for Redshift to S3 using SystemTestContextBuilder pattern.
syedahsn Aug 23, 2022
8fcd0fc
Combine S3 to Redshift, and Redshift to S3 system tests
syedahsn Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 0 additions & 80 deletions airflow/providers/amazon/aws/example_dags/example_s3_to_redshift.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions airflow/providers/amazon/aws/transfers/redshift_to_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class RedshiftToS3Operator(BaseOperator):
'table',
'unload_options',
'select_query',
'redshift_conn_id',
)
template_ext: Sequence[str] = ('.sql',)
template_fields_renderers = {'select_query': 'sql'}
Expand Down
10 changes: 9 additions & 1 deletion airflow/providers/amazon/aws/transfers/s3_to_redshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,15 @@ class S3ToRedshiftOperator(BaseOperator):
:param upsert_keys: List of fields to use as key on upsert action
"""

template_fields: Sequence[str] = ('s3_bucket', 's3_key', 'schema', 'table', 'column_list', 'copy_options')
template_fields: Sequence[str] = (
's3_bucket',
's3_key',
'schema',
'table',
'column_list',
'copy_options',
'redshift_conn_id',
)
template_ext: Sequence[str] = ()
ui_color = '#99e699'

Expand Down
2 changes: 1 addition & 1 deletion docs/apache-airflow-providers-amazon/operators/transfer/redshift_to_s3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ To get more information about this operator visit:

Example usage:

.. exampleinclude:: /../../tests/system/providers/amazon/aws/example_redshift_to_s3.py
.. exampleinclude:: /../../tests/system/providers/amazon/aws/example_redshift_s3_transfers.py
:language: python
:dedent: 4
:start-after: [START howto_transfer_redshift_to_s3]
Expand Down
2 changes: 1 addition & 1 deletion docs/apache-airflow-providers-amazon/operators/transfer/s3_to_redshift.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ To get more information about this operator visit:

Example usage:

.. exampleinclude:: /../../airflow/providers/amazon/aws/example_dags/example_s3_to_redshift.py
.. exampleinclude:: /../../tests/system/providers/amazon/aws/example_redshift_s3_transfers.py
:language: python
:dedent: 4
:start-after: [START howto_transfer_s3_to_redshift]
Expand Down
1 change: 1 addition & 0 deletions tests/providers/amazon/aws/transfers/test_redshift_to_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,4 +297,5 @@ def test_template_fields_overrides(self):
'table',
'unload_options',
'select_query',
'redshift_conn_id',
)
1 change: 1 addition & 0 deletions tests/providers/amazon/aws/transfers/test_s3_to_redshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ def test_template_fields_overrides(self):
'table',
'column_list',
'copy_options',
'redshift_conn_id',
)

def test_execute_unavailable_method(self):
Expand Down
Loading