Skip to content

Add dynamic task mapping example#26678

Closed
Jorricks wants to merge 1 commit intoapache:mainfrom
Jorricks:add_simple_dynamic_example
Closed

Add dynamic task mapping example#26678
Jorricks wants to merge 1 commit intoapache:mainfrom
Jorricks:add_simple_dynamic_example

Conversation

@Jorricks
Copy link
Contributor

Closes #26677

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 26, 2022

We have an embedded example in the doc in dynamic-task-mapping.rst (which is the same appart from the dag_id), can we point to this new example to avoid duplication ?

Also, we are PR driven, meaning that you don't need to create an issue before opening a PR :)

@Jorricks
Copy link
Contributor Author

Jorricks commented Sep 26, 2022

We have an embedded example in the doc in dynamic-task-mapping.rst (which is the same appart from the dag_id), can we point to this example to avoid duplication ?

Also, we are PR driven, meaning that you don't need to create an issue before opening a PR :)

Yes sorry, originally just wanted to raise an issue but didn't want to come over lazy, so also created an example PR.

Anyways, I indeed copied it from there. I think it's good to have an example dag in the code base to test UI functionality for example

@josh-fell
Copy link
Contributor

@Jorricks You might be running up against the same test issues as in #24085 when this was attempted before. However, I do think a core example would indeed be useful if we can overcome the test failures.

@potiuk
Copy link
Member

potiuk commented Sep 27, 2022

@Jorricks You might be running up against the same test issues as in #24085 when this was attempted before. However, I do think a core example would indeed be useful if we can overcome the test failures.

Indeed. It would have been very useful :).

@Jorricks
Copy link
Contributor Author

Jorricks commented Oct 3, 2022

Closed this as the other MRs have more priority and I don't have the time to work on making this work unfortunately :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing DAG example of dynamic task mapping

4 participants