Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 2, 2022

This one removes last remaining downgrade/upgrade scripts to use
pure python Breeze.

This also removes the whole "libraries" folder from our repo,
together with a number of common libraries left.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the remove-downgrade-tests-and-breeze-reminders branch 2 times, most recently from fd49105 to 832c4ea Compare October 2, 2022 13:58
@potiuk potiuk marked this pull request as ready for review October 2, 2022 16:01
@potiuk
Copy link
Member Author

potiuk commented Oct 2, 2022

This PR replaces the "downgrade/upgrade/offline" tests bash scripts with "breeze shell" commands doing the same. Thus we should be able to remove all the remnants of "ci/libraries" and bash scripts from "scripts/ci". There are couple of shell scripts left after that change, but those that are left are probably fine to remain.

This PR completes Breeze conversion to Python

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 @Bowrna @edithturn @eladkal

Note, that it is based on #26612 so only look at the last commit (and we need to merge #26612 first).

@potiuk potiuk force-pushed the remove-downgrade-tests-and-breeze-reminders branch from 832c4ea to 43810a2 Compare October 2, 2022 16:17
@potiuk potiuk mentioned this pull request Oct 2, 2022
This one removes last remaining downgrade/upgrade scripts to use
pure python Breeze.

Thsi also removes the whole "libraries" folder from our repo,
together with a number of common libraries left.
@potiuk potiuk force-pushed the remove-downgrade-tests-and-breeze-reminders branch from 43810a2 to d988c32 Compare October 3, 2022 16:28
@potiuk potiuk changed the title Remove downgrade tests and breeze reminders Move downgrade/upgrade tests to run new Python breeze Oct 3, 2022
@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2022

Should be easy to review:

image

@potiuk potiuk merged commit 803d498 into apache:main Oct 3, 2022
@potiuk potiuk deleted the remove-downgrade-tests-and-breeze-reminders branch October 3, 2022 21:21
ephraimbuddy pushed a commit that referenced this pull request Nov 10, 2022
This one removes last remaining downgrade/upgrade scripts to use
pure python Breeze.

Thsi also removes the whole "libraries" folder from our repo,
together with a number of common libraries left.

(cherry picked from commit 803d498)
ephraimbuddy pushed a commit that referenced this pull request Nov 10, 2022
This one removes last remaining downgrade/upgrade scripts to use
pure python Breeze.

Thsi also removes the whole "libraries" folder from our repo,
together with a number of common libraries left.

(cherry picked from commit 803d498)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 10, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.3 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants