Skip to content

Betterize dataset update blurb#26878

Merged
bbovenzi merged 4 commits intoapache:mainfrom
astronomer:betterize-dataset-update-blurb
Oct 13, 2022
Merged

Betterize dataset update blurb#26878
bbovenzi merged 4 commits intoapache:mainfrom
astronomer:betterize-dataset-update-blurb

Conversation

@blag
Copy link
Contributor

@blag blag commented Oct 5, 2022

This is a follow-up PR to #26815. I will rebase this on main after that PR is merged.

In that PR, in the DAGs view, we display "X of Y Datasets" for all DAGs that are scheduled on one or more datasets.

This is functionally useful except for datasets that are only ever triggered on one dataset. In that case, as long as the consuming DAG isn't paused and isn't currently running (maybe), the Next Run column will always display "0 of 1 Datasets".

Instead of doing that, for DAGs that consume only one dataset, we now simply show that URI:

The Airflow list of DAGs, including the Next Run column, but instead of displaying "0 of 1 Datasets" for DAGs that consume only one dataset it just displays the dataset URI. Everything else about the DAGs list view is unchanged.

The merge commit for this should also be cherry-picked after that merge commit.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 5, 2022
@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 5, 2022

  • I added URI truncation if over 40 characters.
  • Fixed a few issues with the Next run text on dag.html
  • Decided to skip the tooltip text change and opening a modal when there is only one dataset. Instead, we can link directly to the dataset details

@bbovenzi bbovenzi force-pushed the betterize-dataset-update-blurb branch from 8e7e27e to a6ba077 Compare October 12, 2022 17:00
@bbovenzi bbovenzi marked this pull request as ready for review October 12, 2022 18:44
@bbovenzi bbovenzi merged commit 3bcc0b7 into apache:main Oct 13, 2022
@bbovenzi bbovenzi deleted the betterize-dataset-update-blurb branch October 13, 2022 21:00
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants