Merged
Conversation
Instead of showing tracebacks by default, make the end user opt-in instead.
jedcunningham
requested review from
ashb,
dstandish,
ephraimbuddy and
uranusjr
ashb
approved these changes
Oct 14, 2022
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Is it worth changing the tracebace template to mention the config setting? (I.e. so if they get a 500 and want to see tracebacks then get pointed to something to turn it on.)
Member
Author
|
I'd argue the right way to see it is to look at the webserver logs instead? If you start the webserver in debug mode, you get it regardless of this config choice too. |
dstandish
approved these changes
Oct 14, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Instead of showing tracebacks by default, make the end user opt-in instead. (cherry picked from commit 4b113ef)
37 tasks
Member
Quite agree. i think pretty much every time we got reported with the tracebacks originated from the UI, it lacked enough context. |
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 3, 2022
Instead of showing tracebacks by default, make the end user opt-in instead. (cherry picked from commit 4b113ef)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of showing tracebacks by default, make the end user opt-in instead.