Skip to content

Add *.jinja2 files to provider packages #27171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaxil merged 1 commit into from
Oct 21, 2022
Merged

Add *.jinja2 files to provider packages #27171

kaxil merged 1 commit into from
Oct 21, 2022

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Oct 20, 2022 •
edited
Loading

UPDATE this fix didn't quite work. The actual fix is #27451 and should be out in 2.5.0

This ensures that any templates required as part of the provider are included in the distributed packages.

Resolves #26910.

To test this locally, I did this:

./dev/provider_packages/prepare_provider_packages.py generate-setup-files --version-suffix rc1 --no-git-update --verbose --skip-tag-check cncf.kubernetes

then

./dev/provider_packages/prepare_provider_packages.py build-provider-packages --package-format sdist cncf.kubernetes --version-suffix rc1 --no-git-update --skip-tag-check

then check dist folder, expand package, and, there it is.

@dstandish
Add *.jinja2 files to provider packages
c31c957 
This ensures that any templates required as part of the provider are included in the distributed packages.

Resolves apache#26910.
@dstandish
Copy link
Contributor Author

dstandish commented Oct 20, 2022 •
edited
Loading

ok... not there for wheel

@dstandish
Copy link
Contributor Author

dstandish commented Oct 20, 2022

wait... yes it does -- good to go

@dstandish dstandish requested a review from kaxil October 20, 2022 23:08
@kaxil kaxil merged commit 7be7772 into apache:main Oct 21, 2022
@kaxil kaxil deleted the add-jinja2-to-provider-packages branch October 21, 2022 11:34
dstandish added a commit to astronomer/airflow that referenced this pull request Oct 24, 2022
@dstandish
Add *.jinja2 files to provider packages (apache#27171)
e2bb8a5 
This ensures that any templates required as part of the provider are included in the distributed packages.

Resolves apache#26910.

(cherry picked from commit 7be7772)
@dstandish dstandish mentioned this pull request Nov 1, 2022
Merged
dstandish added a commit that referenced this pull request Nov 1, 2022
@dstandish
Fix jinja file inclusion in cncf.kubernetes provider package (#27451)
8975d7c 
Ensures jinja2 files are included in provider package.

Resloves #26910

Followup to PR #27171 (first attempt)
ephraimbuddy pushed a commit that referenced this pull request Nov 10, 2022
@dstandish @ephraimbuddy
Add *.jinja2 files to provider packages (#27171)
8cea072 
This ensures that any templates required as part of the provider are included in the distributed packages.

Resolves #26910.

(cherry picked from commit 7be7772)
@dstandish
Copy link
Contributor Author

dstandish commented Nov 15, 2022

UPDATE this fix didn't quite work. The actual fix is #27451 and should be out in 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@kaxil kaxil kaxil approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees

No one assigned

Labels

area:dev-tools area:providers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python_kubernetes_script.jinja2 file missing from apache-airflow-providers-cncf-kubernetes==4.4.0 release

3 participants

@dstandish @uranusjr @kaxil