Add workeer log-groomer-sidecar enable option in helm chart #27178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
one auto check cancelled. CI timeout? I try to re-trigger it. |
BobDu
force-pushed
the
worker-log-groomer
branch
2 times, most recently
from
9ca2372 to
6aff5dc
Compare
Signed-off-by: BobDu <i@bobdu.cc>
BobDu
force-pushed
the
worker-log-groomer
branch
from
6aff5dc to
cb60f9f
Compare
potiuk
approved these changes
Oct 31, 2022
Member
|
Merging. I think there is little controversy with that. |
Contributor
Author
|
@potiuk maybe we need add it in helm chart 1.8.0 milestone? |
Member
|
No need. Helm Chart is released from main. If things are merged, they will be released in the next version - and we will mark them as the right version. Milestones are used for opened issues that we want to make sure are reviewed and possibly fixed (or pushed to the next release) before we release. |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BobDu i@bobdu.cc
I see #16153 , add scheduler-log-groomer enable option, but not add a same option for worker.
I missing something? @jedcunningham
My airflow cluster use shared efs persistence logs.
But, if every worker start a sidecar container to scan log directory, is unnecessary, and it will use up efs throughout capacity.
We need a option to turn off it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.