Skip to content

Conversation

@JulesTriomphe
Copy link
Contributor

This PR adds a webserverConfigConfigmapName to use a webserver_config.py in a custom configmap.
Specifying a value for this configuration overrides the webserverConfig configuration.

This PR is also designed to solve the issue with readOnlyRootFilesystem clusters, and hence mounts the configmap as a volume for all appropriate containers.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 31, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@JulesTriomphe JulesTriomphe force-pushed the feature/webserverConfigConfigmapName branch 3 times, most recently from ebc51a1 to 27ec6ff Compare November 2, 2022 06:10
@JulesTriomphe
Copy link
Contributor Author

Hi @dstandish and @jedcunningham, this PR is also ready for review

@JulesTriomphe JulesTriomphe force-pushed the feature/webserverConfigConfigmapName branch from 27ec6ff to 5dba900 Compare November 2, 2022 20:27
@JulesTriomphe
Copy link
Contributor Author

The failing check runs fine for me locally. I don't get why it fails here...

@jedcunningham
Copy link
Member

Let's just rerun it as a first attempt, as it seems like a time based failure.

@JulesTriomphe
Copy link
Contributor Author

Looks like it worked. Thanks @jedcunningham !

@JulesTriomphe JulesTriomphe changed the title Add webserverConfigConfigmapName Add webserverConfigConfigMapName Dec 3, 2022
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.8.0 milestone Dec 8, 2022
@jedcunningham jedcunningham merged commit 3f06efa into apache:main Dec 8, 2022
@JulesTriomphe JulesTriomphe deleted the feature/webserverConfigConfigmapName branch December 12, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants