allow pgbouncer replicas to be configurable #27439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XD-DENG
reviewed
Nov 1, 2022
| {{- end }} | ||
| spec: | ||
| replicas: 1 | ||
| replicas: {{ .Values.pgbouncer.replicas }} |
Member
There was a problem hiding this comment.
I understand that you have added the default value in the values.yaml file, but it may be good to have { ... | default 1} here too, so that it will still work in the expected way even if the values file is messed up.
Contributor
Author
There was a problem hiding this comment.
Okay let me add defaults in template
Member
There was a problem hiding this comment.
@XD-DENG, can you expand on "even if the values file is messed up" more? If the values file shipped with the chart is messed up, we are so far from having anything working that duplicating defaults around seems like extra noise to me. Am I missing something?
pgvishnuram
requested review from
XD-DENG
and removed request for
dstandish and
jedcunningham
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
jedcunningham
approved these changes
Nov 1, 2022
28 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows pgbouncer replicas to be configurable and removes hardcoding of values
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.