Changing atlassian JIRA SDK to official atlassian-python-api SDK

[Adityamalik123]

The atlassian-jira provider currently uses JIRA> 1.0.7 dependency which is an unofficial Jira SDK, We need to replace it with the official SDK atlassian-python-api to allow more atlassian product operators in Airflow.
closes : #25669

[eladkal]

Lets also add entry in the provider change log explaining this breaking change

[eladkal]

I don't think we need to catch the exceptions at all?
It will just raise whatever exception coming from the sdk

[Adityamalik123]

Made the changes here by only keeping the HTTPError to log the response from it. Other will just raise with whatever exception that comes. Thanks for identifying this.

[eladkal]

If we remove the notes since no longer relevant shouldn't the code change as well?
to my understanding this code is a workaround to address the issue in comments

[Adityamalik123]

The official SDK returns 'id' in the output in all jira issue related methods. I have added these https://github.com/apache/airflow/pull/27633/files#diff-85731758409b94fa7ff2ab57860f1d4242f7a196768f003e7b618d88254afba4R84-R85 which takes id from the response and performs xcom_push with that.

[eladkal]

same comment/question

[eladkal]

same question

[Adityamalik123]

Made the changes here by only keeping the HTTPError to log the response from it. Other will just raise with whatever exception that comes.
Ref: https://github.com/apache/airflow/pull/27633/files#diff-8edbc4ba86e754ffa8636bf167fa0a0e1eb9bd47f134a1d78103b3b7dad55b10R130

[eladkal]

I think we don't really need this warnings?
we are changing SDKs.. parameters of the previous SDK can just cause confusion.
If users didn't change their usage of the hook nothing won't work anyway.

[Adityamalik123]

Makes sense. I have removed these warnings.

[potiuk]

Can we count on rebase/fixes @Adityamalik123 ?

[Adityamalik123]

@potiuk @eladkal Apologies for the delay, I'll be pushing up the fixes this week.

[Adityamalik123]

Lets also add entry in the provider change log explaining this breaking change

@eladkal Can i add it in the CHANGELOG.rst under a new version or do i have to comment it here and the release manager adds it?

[eladkal]

Lets also add entry in the provider change log explaining this breaking change

@eladkal Can i add it in the CHANGELOG.rst under a new version or do i have to comment it here and the release manager adds it?

Yeah. You need to add it. Check opsgenie change log for example as it had similar case of changing sdk

[Adityamalik123]

Lets also add entry in the provider change log explaining this breaking change

@eladkal Can i add it in the CHANGELOG.rst under a new version or do i have to comment it here and the release manager adds it?

Yeah. You need to add it. Check opsgenie change log for example as it had similar case of changing sdk

Thanks! I have made the changes. Please re-review.

[eladkal]

LGTM
left one comment

[potiuk]

Can you also please update provider.yaml and add 2.0.0 version there?

[Adityamalik123]

Can you also please update provider.yaml and add 2.0.0 version there?

Sure, I have pushed the same.

[eladkal]

Thanks @Adityamalik123
Now it should be easy to add new integrations of atlassian products (service desk or others)