Skip to content

Conversation

@thangnd197
Copy link
Contributor

@thangnd197 thangnd197 commented Nov 15, 2022

This PR add option "preserveAsciiControlCharacters" to valid key list of "src_fmt_configs" of BigQueryHook.run_load()

It help us handle ascii control characters in our data when it is loaded to BigQuery table.

This option is implemented in job api (docs).

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 15, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 15, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@thangnd197 thangnd197 requested review from potiuk and removed request for turbaszek November 21, 2022 06:04
@potiuk potiuk force-pushed the dev_add_preserve_ascii_controll branch from 51ffc17 to cfc6893 Compare December 3, 2022 21:44
@potiuk potiuk merged commit 8f98bfe into apache:main Dec 3, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 3, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants