Add expanded_ti_count to ti context #27680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
XD-DENG,
ashb,
kaxil and
potiuk
as code owners
potiuk
reviewed
Nov 15, 2022
Member
There was a problem hiding this comment.
I guess we should we add "new in 2.5" somewhere?
Member
Author
There was a problem hiding this comment.
I thought about that but it doesn’t seem to fit very well with the current format, and many other variables here (e.g. the data interval ones) don’t annotate when they were added either. Maybe I can revamp the entire table?
Member
Author
There was a problem hiding this comment.
I restructured the entire table.
This value indicates how many tis the current mapped task is mapped into. This will be used to resolve values from parent a mapped task group without needing to call the retrival function repeatedly (which incurs database overhead).
Type information is separated into a separate column, and some additional information is added to the description.
uranusjr
force-pushed
the
mapped-ti-count-in-context
branch
from
aba9e5f to
670f464
Compare
dstandish
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small part of #27678 that can go in independently.
This value indicates how many tis the current mapped task is mapped into. This will be used to resolve values from parent a mapped task group without needing to call the retrival function repeatedly (which incurs database overhead).