Disable nested task mapping for now #27681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
approved these changes
Nov 15, 2022
Member
|
Agreed. |
potiuk
approved these changes
Nov 15, 2022
I think I actually get at least most of the nested logic right-ish, but this restriction is probably a good thing since nested task mapping would require much work in many more places e.g. UI to work well from a user's perspective.
uranusjr
force-pushed
the
disable-nested-task-mapping
branch
from
cc6dcaf to
6a8f814
Compare
ephraimbuddy
added
type:new-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small part of #27678 that can go in independently.
I think I actually get at least most of the nested logic right-ish, but this restriction is probably a good thing since nested task mapping would require much work in many more places e.g. UI to work well from a user's perspective.