Remove get_db_hook method #27762
Closed
Remove get_db_hook method #27762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
|
no concerns with this but either you should keep the old method with deprecation warning or you must bump major |
Contributor
Author
|
Hmm. But this method is defined within |
kazanzhy
force-pushed
the
remove_get_db_hook_method
branch
from
8a6d9b3 to
46962a8
Compare
Contributor
It is user facing as users can build custom operators with it. Any class in providers code that we didnt declare as private should go through deprecation process. |
kazanzhy
force-pushed
the
remove_get_db_hook_method
branch
2 times, most recently
from
dbd3362 to
08e3f65
Compare
kazanzhy
force-pushed
the
remove_get_db_hook_method
branch
from
08e3f65 to
b1a8b85
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
get_db_hookwas used only in DatabricksSqlOperator.These changes might make code cleaner