Chart: add airflow_local_settings to all airflow containers #27779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aakcht
force-pushed
the
local_settings_all_containers
branch
3 times, most recently
from
97e423f to
452cdc3
Compare
potiuk
approved these changes
Nov 25, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM to me. @dstandish @jedcunningham @ephraimbuddy - WDYT?
potiuk
force-pushed
the
local_settings_all_containers
branch
from
452cdc3 to
5584098
Compare
jedcunningham
approved these changes
Nov 29, 2022
Aakcht
force-pushed
the
local_settings_all_containers
branch
from
9e18607 to
94f2ff5
Compare
Contributor
Author
|
@jedcunningham I made the suggested changes, please take a look. It seems that the failed check is not related to this PR, so I'll leave it as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
airflow_local_settingsvolume mount to all containers in the chart that useairflowcommand. This allows to referenceairflow_local_settingsfile in all airflow containers.closes: #25637, closes #27498
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.