Add global volume & volumeMounts to the chart #27781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csp33
force-pushed
the
feature/27687-add-global-volume-volumemounts-to-chart
branch
from
87e11ff to
af0378a
Compare
Member
|
Small fix in static checks. But otherwise LGTM |
csp33
force-pushed
the
feature/27687-add-global-volume-volumemounts-to-chart
branch
from
af0378a to
afd540c
Compare
Contributor
Author
should be fixed now :) |
csp33
force-pushed
the
feature/27687-add-global-volume-volumemounts-to-chart
branch
2 times, most recently
from
afd540c to
c9c0801
Compare
Contributor
|
Static checks are failing |
csp33
force-pushed
the
feature/27687-add-global-volume-volumemounts-to-chart
branch
3 times, most recently
from
02db772 to
2f7fc17
Compare
csp33
force-pushed
the
feature/27687-add-global-volume-volumemounts-to-chart
branch
from
2f7fc17 to
5df056d
Compare
Contributor
Author
Fixed |
jedcunningham
approved these changes
Nov 30, 2022
Contributor
Author
|
Can this PR be merged now? @potiuk @jedcunningham |
Member
|
Thanks @csp33! |
csp33
deleted the
feature/27687-add-global-volume-volumemounts-to-chart
branch
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #27687
Adds a global way to add volumes & volumeMounts for all containers (same as
envfor env vars)