Skip to content

Conversation

@skabbit
Copy link
Contributor

@skabbit skabbit commented Nov 21, 2022

DockerOperator could easily support hostname argument to pass in docker-py APIClient.create_container(). This could be useful in multiple cases, which we had run in.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@skabbit skabbit force-pushed the dockeroperator-hostname-argument branch from 423b1e8 to f52d1dc Compare November 22, 2022 07:28
@skabbit
Copy link
Contributor Author

skabbit commented Nov 22, 2022

@uranusjr please, could you merge this PR?

@potiuk potiuk merged commit 1aa3da5 into apache:main Nov 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 29, 2022

Awesome work, congrats on your first merged pull request!

jrggggg pushed a commit to jrggggg/airflow that referenced this pull request Dec 1, 2022
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Jan 11, 2023
ephraimbuddy pushed a commit that referenced this pull request Mar 8, 2023
@jedcunningham jedcunningham removed this from the Airflow 2.6.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants