Change log level to DEBUG when secret not found for google secret manager #27856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
kaxil
reviewed
Nov 23, 2022
airflow/providers/google/cloud/_internal_client/secret_manager_client.py
Outdated
Show resolved
Hide resolved
lwyszomi
changed the title
potiuk
approved these changes
Dec 3, 2022
2 tasks
84 tasks
|
In which version of Airflow we can see this fix ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Airflow we serching first the connections & variables from alternative secrets backend and then in the databse, so we can have the situation when part of variables/connection we have in database and part of them in the secret backend. In this case we generating a lot of error logs that they are not errors, even if the variable/connection doesn't exist, I think,
infolevel is enough.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.