Skip to content

Conversation

@vandonr-amz
Copy link
Contributor

Add a SageMaker operator that allows registering a model version.

One would think that this takes a model and a version as input, but it's not quite as simple. Registering a model package is actually more like pushing a new version to prod.

I tried to make this as user-friendly as possible by expliciting the required parameters, and adding some of the most common ones, and the rest of the many possible parameters can be specified using kwargs.
The system test can be helpful in understanding what kind of inputs this expects.

Here is the official doc : https://docs.aws.amazon.com/sagemaker/latest/dg/model-registry-version.html
And here is some more context around model versions and package groups: https://docs.aws.amazon.com/sagemaker/latest/dg/model-registry.html

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left few questions / comments

@vandonr-amz
Copy link
Contributor Author

hey @eladkal do you think there are more things to change on this PR ?
if not could you drop your change requested review ? 🙏

@eladkal
Copy link
Contributor

eladkal commented Dec 16, 2022

I'll review this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants