-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add AWS SageMaker operator to register a model's version #28024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Dec 1, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
eladkal
requested changes
Dec 3, 2022
Contributor
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left few questions / comments
uranusjr
approved these changes
Dec 8, 2022
Contributor
Author
|
hey @eladkal do you think there are more things to change on this PR ? |
Contributor
|
I'll review this week |
eladkal
approved these changes
Dec 20, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a SageMaker operator that allows registering a model version.
One would think that this takes a model and a version as input, but it's not quite as simple. Registering a model package is actually more like pushing a new version to prod.
I tried to make this as user-friendly as possible by expliciting the required parameters, and adding some of the most common ones, and the rest of the many possible parameters can be specified using kwargs.
The system test can be helpful in understanding what kind of inputs this expects.
Here is the official doc : https://docs.aws.amazon.com/sagemaker/latest/dg/model-registry-version.html
And here is some more context around model versions and package groups: https://docs.aws.amazon.com/sagemaker/latest/dg/model-registry.html