Skip to content

Conversation

@rob-1126
Copy link
Contributor

@rob-1126 rob-1126 commented Dec 1, 2022

Add a new configurable option (statsd.args) to the helm chart to allow args on the statsd-exporter container to be over-ridden in the same manner as the args on other containers.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 1, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.8.0 milestone Dec 1, 2022
@jedcunningham
Copy link
Member

Merging, sqlite tests failure is unrelated (and flaky).

@jedcunningham jedcunningham merged commit 7f0332d into apache:main Dec 1, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @rob-1126! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants