Skip to content

Conversation

@bhirsz
Copy link
Contributor

@bhirsz bhirsz commented Dec 2, 2022

Our internal CI can produce longer ENV_ID - which would make the trigger name too long. Removed "test" from the name to shorten the trigger name.

Also added a missing teardown method for the trigger.

Change-Id: If78b4ebaab1931919a16c6ad398cb426a0ce5d98
@uranusjr uranusjr merged commit 7adf8a5 into apache:main Dec 6, 2022
@ashb
Copy link
Member

ashb commented Dec 6, 2022

This appears to have broken the docs build

 WARNING: duplicate object description of tests.system.providers.google.cloud.cloud_build.example_cloud_build_trigger.TRIGGER_NAME, other instance in 
_api/tests/system/providers/google/cloud/cloud_build/example_cloud_build_trigger/index, use :noindex: for one of them

File path: apache-airflow-providers-google/_api/tests/system/providers/google/cloud/cloud_build/example_cloud_build_trigger/index.rst (42)

Edit: ah or a PR race with #27783

@potiuk
Copy link
Member

potiuk commented Dec 6, 2022

ah or a PR race with #27783

Yep. Looks like race between the two indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants