Create Lambda create operator and sensor #28241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:amazon
Taragolis
reviewed
Dec 9, 2022
vincbeck
force-pushed
the
vincbeck/lambda
branch
from
582c557 to
4f388f6
Compare
Taragolis
approved these changes
Dec 12, 2022
84 tasks
eladkal
reviewed
Feb 21, 2023
| return response.get("FunctionArn") | ||
|
|
||
|
|
||
| class AwsLambdaInvokeFunctionOperator(BaseOperator): |
Contributor
There was a problem hiding this comment.
Why the Aws prefix?
This is not aligned with the convention #20296
Contributor
Author
There was a problem hiding this comment.
You're totally correct. However, this is not related to this PR, this class existed before this PR, the diff just makes it confusing. I actually dont add AwsLambdaInvokeFunctionOperator but LambdaCreateFunctionOperator.
Though, I agree with you, this should be fixed and we should rename it to have something consistent. I just created #29677, I propose a bit more than renaming AwsLambdaInvokeFunctionOperator to LambdaInvokeFunctionOperator. Let me know what you think (feel free to comment on the issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Lambda create operator and sensor