Bring back psycopg2-binary as dependency instead of psycopg #28316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The psycopg dependency is slightly more optimized than than the binary one, but the problems it creates when it is used as dependency are numerous - it always expects to compile the psycopg dependencies, so you cannot install it when there are no build-essentials installed and on some systems additional libraries are needed. We introduced it in apache#25710 for optimisation reasons. However, the optimisations it brings are not really justified with the installation complexities it introduces, that's why we revert it.
Contributor
|
Saw your convo on Slack, looks like a pretty straight-forward PR 👍 |
Taragolis
approved these changes
Dec 12, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psycopg dependency is slightly more optimized than than the binary one, but the problems it creates when it is used as dependency are numerous - it always expects to compile the psycopg dependencies, so you cannot install it when there are no build-essentials installed and on some systems additional libraries are needed.
We introduced it in #25710 for optimisation reasons.
However, the optimisations it brings are not really justified with the installation complexities it introduces, that's why we revert it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.