Skip to content

Conversation

@xinbinhuang
Copy link
Contributor

@xinbinhuang xinbinhuang commented Dec 21, 2022

Port from: #26664
closes: #9134

Fixed provider metadata to make it pass CI

cc: @chethanuk-plutoflume, sorry for creating a new PR from your branch. I'm hoping to get this merged soon.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@xinbinhuang xinbinhuang force-pushed the binh/add-flink-k8s-operator branch 3 times, most recently from c050a7b to fe138b8 Compare December 21, 2022 00:53
xinbinhuang and others added 2 commits December 20, 2022 17:02
Co-Authored-By: chethanuk-plutoflume <16241795+chethanuk-plutoflume@users.noreply.github.com>
@xinbinhuang xinbinhuang force-pushed the binh/add-flink-k8s-operator branch from fe138b8 to d1ed7e5 Compare December 21, 2022 01:03
@xinbinhuang xinbinhuang changed the title Port https://github.com/apache/airflow/pull/26664 [Fixed] "Adding Flink on K8s Operator" Dec 21, 2022
@xinbinhuang
Copy link
Contributor Author

@potiuk I think the CI has some issue reporting back the error (CI log)

when I ran it locally, I got the traceback:

  File "/Users/binh/.local/bin/breeze", line 8, in <module>
    sys.exit(main())
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/rich_click/rich_group.py", line 21, in main
    rv = super().main(*args, standalone_mode=False, **kwargs)
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/binh/.local/pipx/venvs/apache-airflow-breeze/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/commands/ci_commands.py", line 253, in selective_check
    print(str(sc), file=sys.stderr)
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/utils/selective_checks.py", line 275, in __str__
    output.append(get_ga_output(field_name, getattr(self, field_name)))
  File "/Users/binh/.pyenv/versions/3.9.11/lib/python3.9/functools.py", line 993, in __get__
    val = self.func(instance)
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/utils/selective_checks.py", line 558, in test_types
    current_test_types = set(self._get_test_types_to_run())
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/utils/selective_checks.py", line 539, in _get_test_types_to_run
    affected_providers = find_all_providers_affected(changed_files=self._files)
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/utils/selective_checks.py", line 237, in find_all_providers_affected
    add_dependent_providers(all_providers, provider, dependencies)
  File "/Users/binh/projects/airflow/dev/breeze/src/airflow_breeze/utils/selective_checks.py", line 223, in add_dependent_providers
    for dep_name in dependencies[provider_to_check]["cross-providers-deps"]:
KeyError: 'apache.flink'

Any clues if we can fix the CI to report back the traceback properly?

@xinbinhuang xinbinhuang requested a review from potiuk December 21, 2022 01:08
@potiuk
Copy link
Member

potiuk commented Dec 21, 2022

Good one. Unforeseen interaction of stderr redirection to GITHUB_OUTPUT.

Fix (for the future) in #28514 (explanation in the commit descripton - and you can see the changes in the PR :)

@xinbinhuang xinbinhuang force-pushed the binh/add-flink-k8s-operator branch from 39a1d8f to d7ffde1 Compare December 21, 2022 02:04
@xinbinhuang xinbinhuang requested a review from kaxil as a code owner December 21, 2022 02:04
@xinbinhuang xinbinhuang force-pushed the binh/add-flink-k8s-operator branch from d7ffde1 to c1d7188 Compare December 21, 2022 02:10
@xinbinhuang xinbinhuang force-pushed the binh/add-flink-k8s-operator branch from 7103b2f to cbfb395 Compare December 21, 2022 03:45
@chethanuk
Copy link
Contributor

Awesome thanks for fixing breeze cross-providers-deps @xinbinhuang

@xinbinhuang
Copy link
Contributor Author

xinbinhuang commented Dec 21, 2022

@potiuk @jedcunningham CI green ✅ . Would you help take a look?

@kaxil kaxil merged commit 681835a into apache:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:cncf-kubernetes Kubernetes (k8s) provider related issues type:new-feature Changelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Flink operator

5 participants