Defer to hook setting for split_statements in SQLExecuteQueryOperator #28635
Conversation
|
I don't think this breaks any backcompat because for most providers this is no change and, for snowflake , if you try to submit multistatement r.n. with defaults it will just fail (and this effectively restores the behavior prior to the big sql refactor) |
We should be very explicit about this in the release notes though if we merge this change (which I am in favor of), because it potentially alters DAG behavior. |
dstandish
force-pushed
the
defer-to-hook-for-split-statements
branch
from
9a9644f to
405ed43
Compare
Some databases, such as snowflake, require you to split statements in order to submit multi-statement sql. For such databases, splitting is the natural default, and we should defer to the hook to control that.
dstandish
force-pushed
the
defer-to-hook-for-split-statements
branch
from
faaad8a to
1035a2a
Compare
| if self.split_statements is not None: | ||
| extra_kwargs = {"split_statements": self.split_statements} | ||
| else: | ||
| extra_kwargs = {} |
There was a problem hiding this comment.
| if self.split_statements is not None: | |
| extra_kwargs = {"split_statements": self.split_statements} | |
| else: | |
| extra_kwargs = {} | |
| extra_kwargs = {"split_statements": self.split_statements} if self.split_statements else {} |
There was a problem hiding this comment.
thanks for the suggestion. current form is result of TP's suggestion. just gonna leave it as is.
3 participants
Some databases, such as snowflake, require you to split statements in order to submit multi-statement sql. For such databases, splitting is the natural default and most intuitive setting, and we should defer to the hook to control that.
cc @potiuk @eladkal @kazanzhy @pgagnon