Skip to content

Conversation

@sudeepgupta90
Copy link
Contributor

closes: #28604
This PR aims to add the annotations to the deployment objects for the following Airflow components:

  • Webserver
  • Scheduler
  • Triggerer
  • Flower
  • Dags processor
  • Pgbouncer
  • Worker

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 3, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sudeepgupta90 sudeepgupta90 force-pushed the bugfix/28604_helm_annotations branch from 6283e48 to 6f3a2db Compare January 3, 2023 10:47
@sudeepgupta90
Copy link
Contributor Author

The initial workflow failed on a spell check, and I have pushed a correction after verifying this locally.

@sudeepgupta90 sudeepgupta90 force-pushed the bugfix/28604_helm_annotations branch 2 times, most recently from 0c63ab7 to 6d14620 Compare January 5, 2023 11:47
@sudeepgupta90 sudeepgupta90 force-pushed the bugfix/28604_helm_annotations branch from 6d14620 to e17c9e9 Compare January 6, 2023 05:58
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.8.0 milestone Jan 6, 2023
@jedcunningham jedcunningham merged commit 451d6c0 into apache:main Jan 6, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 6, 2023

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @sudeepgupta90, congrats on your first commit 🎉

@sudeepgupta90 sudeepgupta90 deleted the bugfix/28604_helm_annotations branch January 7, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing annotations on Deployments

3 participants