Fix dag run conf encoding with non-JSON serializable values #28777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
Taragolis
reviewed
Jan 7, 2023
Contributor
|
I've just merged all encoders into (almost) one. Let's not add another one and extend the one used for the Web if required (There is a WebEncoder). |
hussein-awala
force-pushed
the
fix/dag_run_encoding
branch
from
b27f641 to
66d2066
Compare
hussein-awala
requested review from
XD-DENG,
dstandish,
eladkal,
ephraimbuddy,
jedcunningham,
josh-fell,
kaxil,
mik-laj,
o-nikolas,
potiuk and
turbaszek
as code owners
hussein-awala
force-pushed
the
fix/dag_run_encoding
branch
2 times, most recently
from
7717e93 to
2136340
Compare
uranusjr
reviewed
Feb 10, 2023
hussein-awala
force-pushed
the
fix/dag_run_encoding
branch
from
f8d3618 to
ac22328
Compare
hussein-awala
requested review from
uranusjr
and removed request for
bolkedebruin
uranusjr
reviewed
Feb 13, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Feb 13, 2023
Member
Author
|
@Taragolis @bolkedebruin I think we need a second approve to merge this PR, can you please review it? |
potiuk
approved these changes
Apr 3, 2023
This was referenced Jul 5, 2023
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #28772
^ Add meaningful description above
This PR creates a custom json encoder class to encode non-JSON serializable values added to the dag run conf dictionary.
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.