-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add worker service account for LocalKubernetesExecutor #28813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
c298f14 to
7966c7a
Compare
|
Thanks @Chen-Oliver. Can you add some test coverage for the various executor options here as well? |
I've added a simple test, hopefully it is sufficient :) |
7ad6c5d to
5ab6286
Compare
|
rebased to account for doc failure fixed in main |
|
Awesome work, congrats on your first merged pull request! |
|
Thanks @Chen-Oliver! Congrats on your first commit 🎉 |
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"pods \"extract-57f0f8f6590045d59eb2d36ce2bacb53\" is forbidden: error looking up service account airflow/airflow-worker: serviceaccount \"airflow-worker\" not found","reason":"Forbidden","details":{"name":"extract-57f0f8f6590045d59eb2d36ce2bacb53","kind":"pods"},"code":403}WARNING - ApiException when attempting to run task, re-queueing. Reason: 'Forbidden'. Message: pods "extract-57f0f8f6590045d59eb2d36ce2bacb53" is forbidden: error looking up service account airflow/airflow-worker: serviceaccount "airflow-worker" not foundWhen using the
KubernetesExecutoras part ofLocalKubernetesExecutor, it will fail due to a missing worker service account. This PR fixes that issue. Have tested this fix on the latest helm chart version.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.