Bugfix/global volumes in pod template file and formatting #29288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesTriomphe
requested review from
dstandish and
jedcunningham
as code owners
JulesTriomphe
force-pushed
the
bugfix/global-volumes-in-pod-template-file-and-formatting
branch
from
3d318ff to
15c64d4
Compare
JulesTriomphe
force-pushed
the
bugfix/global-volumes-in-pod-template-file-and-formatting
branch
from
15c64d4 to
35c59c9
Compare
Contributor
Author
|
Hi @jedcunningham I've checked this release by testing, deploying and running some DAGs. It's OK to merge |
Member
|
@JulesTriomphe, can you split this into 2 PRs? It'll be better that way in the release notes. Thanks! |
This was referenced Feb 1, 2023
Contributor
Author
|
Sure @jedcunningham , cf #29295, #29296 and #29297 (found it better to make 3 as the two formatting issues are distinct). |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globally defined volumes are missing in the pod-template-file which will make pod spawning fail on clusters where readOnlyRootFilesystem is True and a volume for airflow home has been set globally. Workaround would be to set that volume in each system's extraVolumes and extraVolumeMounts but that would greatly reduce the functionality of global volumes and volume mounts.
This PR fixes that issue.
related: #29273