Add ttlSecondsAfterFinished to migrateDatabaseJob and createUserJob #29314
Conversation
alexandermalyga
requested review from
dstandish and
jedcunningham
as code owners
| {{- $annotations | toYaml | nindent 4 }} | ||
| {{- end }} | ||
| spec: | ||
| {{- if not (kindIs "invalid" .Values.createUserJob.ttlSecondsAfterFinished) }} |
There was a problem hiding this comment.
Checking specifically for not nil because 0 is a valid value for this field and it would evaluate to false normally.
|
Ah, I missed that one and it's a better fix than mine #29439 |
There was a problem hiding this comment.
This is better than mine - also @hussein-awala suggest that we could rename the jobs so that it will also work even if update is done quickly. See #29439 (review)
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
OK. Pending the two small comments @dstandish @jedcunningham - in case you think there is a reason why job name cannot be changed, pleas shout :)
I tried and this affects a lot of tests, let's do it in a separate PR? |
I am fine with it. |
2 participants
related: #27561
Adds the ttlSecondsAfterFinished parameter to
migrateDatabaseJobandcreateUserJob, so job objects can be automatically deleted after execution.