Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Feb 4, 2023

This PR fixes some glitches that I found in the contribution of AIP-50 which slipped into the code at point of final review. I detected these during demo of the feature and hereby what to provide a fix.

Three glitches corrected with this PR:

  • The DAG embedded javascript demo of the color slides in the example_params_ui_tutorial were broken
  • The HTML dict formatting of the box/section "Generated Configuration JSON" in the new trigger UI (e.g. in "example_params_ui_tutorial" or other DAGs with a submit form was misaligned. setTimeout() event handler generates JavaScript error
  • A TypeError was raised in JavaScript on first form submission when no "Select Recent Configurations" was rendered on page.

How to test that this fix works:

  • Check out this branch, clean your dev env and re-compile www assets
  • Start a local instance and open the browser to http://localhost:28080/trigger?dag_id=example_params_ui_tutorial
  • See that (assuming you never ran the DAG) no JavaScript error is reported in JavaScript Developer Console
  • Click on the gray section bar "Generated Configuration JSON" and see that dict formatting is "nice" (no mis-aligned text compared to main)
  • Click on the gray section bar "Special advanced stuff with form fields" and use the sliders to adjust demo of color picker. See that color and text value adjusts when changing sliders and other way around if you change color code the sliders adjust. (was broken on main)

closes: #26215

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 4, 2023
@jedcunningham jedcunningham added this to the Airflow 2.6.0 milestone Feb 5, 2023
@bbovenzi
Copy link
Contributor

bbovenzi commented Feb 9, 2023

@jens-scheffler-bosch Mind rebasing so the checks can pass?

@jscheffl
Copy link
Contributor Author

jscheffl commented Feb 9, 2023

@jens-scheffler-bosch Mind rebasing so the checks can pass?

Was not able to follow-up the status of red-main which I saw in slack, thanks for the hint, let's try to make pipeline green now :-D

@bbovenzi bbovenzi merged commit 9c6f83b into apache:main Feb 11, 2023
@pierrejeambrun pierrejeambrun added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) AIP-50 Trigger DAG UI user Form labels Feb 27, 2023
@jscheffl jscheffl deleted the bugfix/26215-remove-trigger-ui-glitches branch October 28, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-50 Trigger DAG UI user Form area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger DAG UI Extension w/ Flexible User Form Concept

4 participants