Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 13, 2023

The "all" alias outgrew original meaning with adding statsd integration in #29449 which resulted in a problem fixed by #29517. The "all" tests as result was not "all" but "all that could be tested".

This PR adds "all-testable" alias which as opposed to "all" does not contain "statsd" - it also renames some of the vars/arrays to reflect it.7


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the rename-all-tests-to-all-testable branch 2 times, most recently from 86198da to 0591453 Compare February 13, 2023 23:38
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

The "all" alias outgrew original meaning with adding statsd integration
in apache#29449 which resulted in a problem fixed by apache#29517. The "all" tests
as result was not "all" but "all that could be tested".

This PR adds "all-testable" alias which as opposed to "all" does not
contain "statsd" - it also renames some of the vars/arrays to reflect
it.7
@potiuk potiuk force-pushed the rename-all-tests-to-all-testable branch from 0591453 to a643e82 Compare February 16, 2023 13:14
@potiuk potiuk merged commit 5627522 into apache:main Feb 17, 2023
@potiuk potiuk deleted the rename-all-tests-to-all-testable branch February 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants