-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Decouple production executor warning in dags UI #29609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@o-nikolas looks like there are a few failing tests. Once these are fixed would be glad to merge. |
fab2657 to
947e546
Compare
|
I think it needs rebase. |
|
Interesting development: |
|
Thoughts on the above anyone? |
|
Scraping it sounds reasonable to me |
|
Yep. Scrap it @o-nikolas |
|
Thanks for the feedback! I'll scrap it for now 👍 |
|
Sorry for the confusion, but this code is still needed after all. I thought things had changed in a way that they haven't. I'll update this PR today |
Previously the views code was hardcoded to look out for the SequentialExecutor and warn to not use it in production. This change makes that generalized to any non-production executor
947e546 to
79d36d0
Compare
|
Sorry again for the confusion, but this PR is ready again for review 🙏 |
|
LGTM |
This reverts commit 88ed20a.
Previously the views code was hardcoded to look out for the SequentialExecutor and warn to not use it in production. This change makes that generalized to any non-production executor.
Some screenshots below:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.