Fix Scheduler crash when clear a previous run of a normal task that is now a mapped task #29645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s now a mapped task The fix was to clear the db references of the taskinstances in XCom, RenderedTaskInstanceFields and TaskFail. That way, we are able to run the mapped tasks
potiuk
approved these changes
Feb 20, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice!. Love the attention to detail and test reproducing the scenario
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was to clear the db references of the taskinstances in XCom, RenderedTaskInstanceFields, and TaskFail. That way, we are able to run the mapped tasks
Closes: #27478