fix update_mask in patch variable route #29711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
hussein-awala
requested review from
uranusjr
and removed request for
ephraimbuddy
dimberman
previously requested changes
Feb 23, 2023
Member
Author
|
@dimberman Can you please review my last commit? |
uranusjr
reviewed
Mar 9, 2023
Member
|
@dimberman ? Is your "request changes" still valid ? I think it has been addressed but I would not want to dismiss the review without you confirming. |
Member
|
Since you have not responded @dimberrman, I will simply dismiss it. 2 weeks and no response despite pinging seems to be enough. We can always have a follow-up if the "request for changes" is still not resolved. |
potiuk
approved these changes
Mar 18, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit de8e07d)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29702
patch_variableroute does not allow updating the variable description. This PR updates the method and uses the same pattern used in the other routes to dynamically update all the fields which are notnon_update_fields.