Exclude v1.58 of PyGithub package in GitHub provider
#29728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not entirely sure if this is too aggressive, but I definitely welcome feedback. Is it worth coming up with a serializer for the provider to handle the stateful object? |
Member
|
It looks like - from your issue @josh-fell that they are eyeying fixing it. So I would rather use != 1.58 now. |
Contributor
Author
Sounds good, thanks @potiuk. I honestly wasn't sure how to interpret the response. I'll update the constraint. |
Contributor
Author
|
Actually it looks like a PR was opened several hours ago to fix it. 🎉 |
Starting with v1.58 of `PyGithub`, serialization with `pickle` of `Repository`, `NamedUser`, `Issue`, and other `github.Github.GithubObject`s is no longer possible out of the box. Users won't be able to pass these objects in XCom if desired when using the GitHhub provider.
josh-fell
changed the title
PyGithub packagePyGithub package in GitHub provider
potiuk
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: PyGithub/PyGithub#2436
Starting with v1.58 of
PyGithub, serialization withpickleofRepository,NamedUser,Issue, and othergithub.Github.GithubObjects is no longer possible out of the box. Users won't be able to pass these objects in XCom if desired.