Fixing broken filter in /taskinstance/list view #29850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWheating
changed the title
SamWheating
force-pushed
the
sw-fix-trynumber-filter-in-ti-view
branch
3 times, most recently
from
ac75360 to
66fa2b4
Compare
uranusjr
reviewed
Mar 2, 2023
SamWheating
force-pushed
the
sw-fix-trynumber-filter-in-ti-view
branch
from
66fa2b4 to
d520bf6
Compare
potiuk
reviewed
Mar 4, 2023
SamWheating
force-pushed
the
sw-fix-trynumber-filter-in-ti-view
branch
from
c3047e5 to
0948f2c
Compare
uranusjr
approved these changes
Mar 7, 2023
potiuk
approved these changes
Mar 7, 2023
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
force-pushed
the
sw-fix-trynumber-filter-in-ti-view
branch
from
0948f2c to
61e62ae
Compare
Member
|
Rebased to account for the caching/pipx issue. |
Contributor
|
this is not yet in 2.5.2 right? 🤔 |
Member
|
Should be. Did you check release notes? |
Member
|
FYI @pierrejeambrun @ephraimbuddy - > looks like this one was marked to 2.5.2 but was not cherry-picked. I guess it was some race condition (merging it around the release cut time). I moved it to 2.5.3 |
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit a3c9902)
pierrejeambrun
changed the title
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29843
Because the column and column in the DB are both called
try_number, flask-appbuilder ends up trying to build a filter using thetry_numberproperty, which doesn't work.I think that we could get around this by renaming the property, but that would be a huge refactor. Instead, we can just use the
@hybrid_propertydecorator which will enable different behaviour at the class vs. instance-level.(more on sqlalchemy hybrid properties here)
Tested this in breeze and can confirm it works:
Will wait for the full tests to run before I claim that this doesn't break anything else 🤞