Mask out non-access bits when comparing file modes #29886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #29112 I found another issue in the way that the file task handler checks file access:
airflow/airflow/utils/log/file_task_handler.py
Lines 439 to 445 in 9745032
The return value of
path.stat().st_modewill include additional bits beyond the tailing 9 access bits (-RWXRWXRWX), which can lead to runningchmodwhen it isn't required, as demonstrated here:I'm not sure if this is the main cause of #29112, as there could be remaining issues around kubernetes security groups etc, but I think that this bug could definitely lead to unnecessarily chmod'ing directories without being the owner which could then throw the reported errors.