Fix tags selection in DAGs UI #29944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemikhaylov
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
bbovenzi
approved these changes
Mar 8, 2023
Contributor
|
changing to 2.5.3 as 2.5.2 deadline has passed |
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit 8691c4f)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 24, 2023
(cherry picked from commit 8691c4f)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags selection doesn't work for me without the fix (select2 on change event doesn't contain
val, so the tags cannot be read from there).Google Chrome: Version 109.0.5414.119 (Official Build) (x86_64)
jQuery v3.6.0
Before:
airflow_tags_before_720.mov
After:
airflow_tags_test_480.mov