-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix some long known Graph View UI problems #29971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looking good. Do you mind running |
|
Also, the new graph view doesn't have the first problem. But I'll make sure the second problem is also addressed before 2.6.0 is released. |
graph zoom changes Fix find zoom Remove unused args Refactor
Thanks for pointing out. Done. It did uncover an unused variable.
That sounds great. Is there a place to preview what 2.6.0 graph will look like? |
Either run airflow locally, or you can see some screenshots/gifs in the PR: #29413 |
|
@yuqian90 wdyt of expand/collapse like this? |
This looks awesome. Does it scale well with large DAGs? e.g. one that has hundreds of tasks and many TaskGroups? |
Working on it! If not, maybe we'll just disable animations if there are 1000+ tasks. |
* Center clicked node around mouse graph zoom changes Fix find zoom Remove unused args Refactor * rebase * revert redundant change * Fix unused variable * pre-commit --------- Co-authored-by: Qian Yu <qian@hudson-trading.com> (cherry picked from commit ff9cae9)
* Center clicked node around mouse graph zoom changes Fix find zoom Remove unused args Refactor * rebase * revert redundant change * Fix unused variable * pre-commit --------- Co-authored-by: Qian Yu <qian@hudson-trading.com> (cherry picked from commit ff9cae9)

We often hear these two complaints from users:
This PR fixes both issues.
Here's a gif showing some of the UI interactions after this change. Notice these two changes: