Avoid considering EmptyOperator in mini scheduler #29979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmptyOperator should not be executed on workers thus it should not be considered for the mini scheduler optimization. closes: apache#29974
eladkal
force-pushed
the
ti
branch
2 times, most recently
from
bd23b18 to
2f21990
Compare
potiuk
approved these changes
Mar 8, 2023
Member
|
NIce one. |
Member
|
It should probably check for callbacks and outlets as well: airflow/airflow/models/dagrun.py Lines 1262 to 1264 in c386778 Or, just letting the scheduler deal with it instead is probably fine too. I'm good either way. |
ephraimbuddy
reviewed
Mar 8, 2023
…ini scheduler. for example: EmptyOperator with on_execute_callback, on_success_callback, outlets
Contributor
Author
|
@jedcunningham good point. added handling for that cases |
jedcunningham
approved these changes
Mar 8, 2023
2 tasks
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 24, 2023
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyOperator should not be executed on workers thus it should not be considered for the mini scheduler optimization. closes: #29974
TODO:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.