Skip to content

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Mar 10, 2023

Shell expansion is not working for those two commands. (globing)

Related: #3740

The other way would be to rewrite this in a more 'pythonic' way, for instance using shutil, os.listdir, and such.

But for svn add we would need https://pypi.org/project/svn/ I guess

@pierrejeambrun pierrejeambrun force-pushed the fix-breeze-release-management-shell-expansion branch 2 times, most recently from 635987c to 3587387 Compare March 10, 2023 19:28
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.3 milestone Mar 10, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 10, 2023
@ephraimbuddy
Copy link
Contributor

Can you also do the same for this:

run_command(["pushd", "dist"], dry_run_override=DRY_RUN, check=True)
run_command(["./dev/sign.sh", "*"], dry_run_override=DRY_RUN, check=True)
run_command(["popd"], dry_run_override=DRY_RUN, check=True)
,
It failed. Should be one single command instead of all 3

@pierrejeambrun pierrejeambrun force-pushed the fix-breeze-release-management-shell-expansion branch from 3587387 to 2abf9ad Compare March 10, 2023 22:00
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Mar 10, 2023

Yes of course. I just updated the signing command, tested locally and working nicely.

We also avoid using pushd and popd which are not supported in 'sh'. (default executable of the subprocess module).

edit: More info in this post

@pierrejeambrun pierrejeambrun merged commit 3bac8f7 into apache:main Mar 11, 2023
@pierrejeambrun pierrejeambrun deleted the fix-breeze-release-management-shell-expansion branch March 11, 2023 13:07
pierrejeambrun added a commit that referenced this pull request Mar 23, 2023
pierrejeambrun added a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants