Skip to content

Remove upper bound limit of astroid #30033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Mar 11, 2023
Merged

Remove upper bound limit of astroid #30033

potiuk merged 2 commits into from
Mar 11, 2023

Conversation

@auvipy
Copy link
Contributor

@auvipy auvipy commented Mar 11, 2023

The issue was fixed & released so removing the upper bound

eladkal
eladkal reviewed Mar 11, 2023
View reviewed changes
setup.py Outdated
# Astroid 2.12.* breaks documentation building
# We can remove the limit here after https://github.com/PyCQA/astroid/issues/1708 is solved
"astroid<2.12.0",
"astroid",
Copy link
Contributor

@eladkal eladkal Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"astroid",
"astroid>=2.12.3",

Don't we need to bump to the version that contains the fix?
or at least skip the ones known to have the issue: !=2.12.0, !=2.12.1, !=2.12.2 ?

Copy link
Contributor Author

@auvipy auvipy Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@potiuk potiuk merged commit fc3917e into apache:main Mar 11, 2023
@auvipy
Copy link
Contributor Author

auvipy commented Mar 11, 2023

thanks

@potiuk
Copy link
Member

potiuk commented Mar 11, 2023

Thank you !

@vchiapaikeo
Copy link
Contributor

vchiapaikeo commented Mar 12, 2023 •
edited
Loading

Seeing this issue when trying to start breeze on latest w/ breeze --python 3.9 --backend postgres start-airflow:

#0 6.661 ERROR: Cannot install apache-airflow[devel-ci]==2.6.0.dev0 because these package versions have conflicting dependencies.
#0 6.662
#0 6.662 The conflict is caused by:
#0 6.662     apache-airflow[devel-ci] 2.6.0.dev0 depends on astroid>=2.12.3
#0 6.662     The user requested (constraint) astroid==2.11.7
#0 6.662
#0 6.662 To fix this you could try to:
#0 6.662 1. loosen the range of package versions you've specified
#0 6.662 2. remove package versions to allow pip attempt to solve the dependency conflict
#0 6.662
#0 6.662 ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
------
ERROR: failed to solve: executor failed running [/bin/bash -o pipefail -o errexit -o nounset -o nolog -c bash /scripts/docker/install_airflow.sh]: exit code: 1
Your image build failed. It could be caused by conflicting dependencies.
Run `breeze ci-image build --upgrade-to-newer-dependencies` to upgrade them.

Creating network "docker-compose_default" with the default driver
Pulling airflow (ghcr.io/apache/airflow/main/ci/python3.9:latest)...
latest: Pulling from apache/airflow/main/ci/python3.9

Do constraints need to be updated somehow?

@potiuk
Copy link
Member

potiuk commented Mar 12, 2023 •
edited
Loading

Yes. They should update itself automatically (but it can a little time depending on the success of main build).

As a temp solution you should follow the advice given (if you look closely the advice was given very precisely) :

Your image build failed. It could be caused by conflicting dependencies.
Run breeze ci-image build --upgrade-to-newer-dependencies to upgrade them.

@potiuk
Copy link
Member

potiuk commented Mar 12, 2023

Yep. The constraints with updated astroid have just been pushed after main success: 69b9d24

So it should work now without need to add the flag

@auvipy auvipy deleted the patch-1 branch March 12, 2023 04:09
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.3 milestone Mar 22, 2023
@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 22, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 23, 2023
@auvipy @pierrejeambrun
Remove upper bound limit of astroid (#30033)
7332970 
* Remove upper bound limit of astroid

* "astroid>=2.12.3"

(cherry picked from commit fc3917e)
pierrejeambrun pushed a commit that referenced this pull request Mar 24, 2023
@auvipy @pierrejeambrun
Remove upper bound limit of astroid (#30033)
0aa97d8 
* Remove upper bound limit of astroid

* "astroid>=2.12.3"

(cherry picked from commit fc3917e)
@pierrejeambrun pierrejeambrun mentioned this pull request Mar 27, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkal eladkal eladkal left review comments

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@auvipy @potiuk @vchiapaikeo @eladkal @pierrejeambrun