Fix TriggerRuleDep when the mapped tasks count is 0
#30084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Mar 14, 2023
potiuk
force-pushed
the
fix/trigger_rule_with_none_mapped_tasks
branch
from
9f638b8 to
c529bf1
Compare
uranusjr
approved these changes
Mar 15, 2023
potiuk
approved these changes
Mar 15, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Fix TriggerRuleDep when the mapped tasks count is 0 * merge the two checks in a simple one (cherry picked from commit 8d22828)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Fix TriggerRuleDep when the mapped tasks count is 0 * merge the two checks in a simple one (cherry picked from commit 8d22828)
28 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #30073
To calculate
ancestor_map_index, we dividemap_index * ancestor_ti_countbyti_countwhich can be zero when we expand a task group and we provide an empty list as argument, in this case the scheduler enter in a crush loop.In this PR I add a check for 0 value and a test to check if the
TriggerRuleDepworks with empty expended lists.