Skip to content

Conversation

@meujin
Copy link
Contributor

@meujin meujin commented Mar 14, 2023

Fix the problem with creating URL for the taskinstance.

When you go to /taskinstance/list/ URL every runid in the table would be without the execution_date query param, which will cause a redirect to the latest graph when clicking on it instead of needed. That happened because execution_date was not found in attrs because of a spelling mistake.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Fix problem with creating url for taskinstance
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@bbovenzi bbovenzi added this to the Airflow 2.5.3 milestone Mar 14, 2023
@bbovenzi bbovenzi changed the title Update utils.py Fix spelling mistake in wwwutils.dag_run_link Mar 14, 2023
@uranusjr uranusjr merged commit 971a736 into apache:main Mar 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 15, 2023

Awesome work, congrats on your first merged pull request!

@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Mar 22, 2023
@pierrejeambrun pierrejeambrun changed the title Fix spelling mistake in wwwutils.dag_run_link Fix wwwutils.dag_run_link redirection Mar 22, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 23, 2023
@pierrejeambrun pierrejeambrun changed the title Fix wwwutils.dag_run_link redirection Fix www/utils.dag_run_link redirection Mar 24, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants